Skip to content

fix(switch): only showing check if show-check-icon is true#2208

Merged
bennypowers merged 2 commits intomainfrom
bug-2207/switch-check-always-present
Oct 28, 2022
Merged

fix(switch): only showing check if show-check-icon is true#2208
bennypowers merged 2 commits intomainfrom
bug-2207/switch-check-always-present

Conversation

@kylebuch8
Copy link
Copy Markdown
Contributor

@kylebuch8 kylebuch8 commented Oct 28, 2022

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 28, 2022

⚠️ No Changeset found

Latest commit: be37a53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass work in progress POC / Not ready for review AT passed Automated testing has passed labels Oct 28, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 28, 2022

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 4934a24
😎 Deploy Preview https://deploy-preview-2208--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@kylebuch8 kylebuch8 marked this pull request as ready for review October 28, 2022 15:16
@kylebuch8 kylebuch8 requested a review from zeroedin October 28, 2022 15:17
Comment thread elements/pfe-switch/BaseSwitch.ts Outdated
Copy link
Copy Markdown
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let good times manifest

@bennypowers bennypowers merged commit 40bd347 into main Oct 28, 2022
@bennypowers bennypowers deleted the bug-2207/switch-check-always-present branch October 28, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass work in progress POC / Not ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

switch: check is always showing

3 participants