Skip to content

feat(card): pfe-card 1:1 #2222

Merged
bennypowers merged 42 commits intomainfrom
feat/pfe-card-pfv4
Dec 20, 2022
Merged

feat(card): pfe-card 1:1 #2222
bennypowers merged 42 commits intomainfrom
feat/pfe-card-pfv4

Conversation

@brianferry
Copy link
Copy Markdown
Collaborator

Updating the pfe-card component to match the styles and attributes of the pfv4 card component.

Related issues

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 3, 2022

🦋 Changeset detected

Latest commit: 98e3a58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-card Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added work in progress POC / Not ready for review demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass AT passed Automated testing has passed labels Nov 3, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 3, 2022

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit c957fdf
😎 Deploy Preview https://deploy-preview-2222--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions Bot added the doc label Nov 8, 2022
@brianferry brianferry marked this pull request as ready for review November 10, 2022 15:37
@bennypowers bennypowers changed the title [feat] pfe-card 1:1 feat(card): pfe-card 1:1 Nov 28, 2022
Copy link
Copy Markdown
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good, Brian

A few things to change, we'll have this merged soon

Comment thread elements/pfe-card/demo/pfe-card.html Outdated
Comment thread elements/pfe-card/pfe-card.scss
Comment thread elements/pfe-card/pfe-card.ts
Comment thread elements/pfe-card/BaseCard.ts
Comment thread elements/pfe-card/pfe-card.ts Outdated
Comment thread elements/pfe-card/test/pfe-card.spec.ts Outdated
Comment thread elements/pfe-card/test/pfe-card.spec.ts Outdated
Comment thread elements/pfe-card/test/pfe-card.spec.ts Outdated
@bennypowers bennypowers enabled auto-merge (squash) December 20, 2022 13:17
Copy link
Copy Markdown
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legitimately Great Taskwork, Man

@bennypowers bennypowers merged commit 0298953 into main Dec 20, 2022
@bennypowers bennypowers deleted the feat/pfe-card-pfv4 branch December 20, 2022 14:12
@bennypowers bennypowers mentioned this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. ready to merge styles An issue or PR pertaining only to CSS/Sass tests Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants