Skip to content

test(card): fix test file#2278

Merged
bennypowers merged 1 commit intomainfrom
test/card/fix-typescript-errors
Dec 20, 2022
Merged

test(card): fix test file#2278
bennypowers merged 1 commit intomainfrom
test/card/fix-typescript-errors

Conversation

@bennypowers
Copy link
Copy Markdown
Member

What I did

skip and comment out the flaky a11ySnapshot test for card. We should revisit this later, but for now it's just a time sink.

This block release so please merge ASAP

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 20, 2022

⚠️ No Changeset found

Latest commit: efd628c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bennypowers bennypowers enabled auto-merge (squash) December 20, 2022 14:37
@github-actions github-actions Bot added the tests Related to testing label Dec 20, 2022
Copy link
Copy Markdown
Collaborator

@brianferry brianferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we'll need to do some testing around incorporating these snapshots in the future

@bennypowers bennypowers merged commit 63f752b into main Dec 20, 2022
@bennypowers bennypowers deleted the test/card/fix-typescript-errors branch December 20, 2022 14:40
@github-actions
Copy link
Copy Markdown
Contributor

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 07ef844
😎 Deploy Preview https://deploy-preview-2278--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions Bot added the AT passed Automated testing has passed label Dec 20, 2022
Copy link
Copy Markdown
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets Get This Moving

@zeroedin
Copy link
Copy Markdown
Collaborator

Lets Get This Moving

Was a bit late on this one 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed tests Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants