Skip to content

Comments

chore: fix ts build#2284

Merged
bennypowers merged 4 commits intomainfrom
chore/fix-ts-errors
Dec 29, 2022
Merged

chore: fix ts build#2284
bennypowers merged 4 commits intomainfrom
chore/fix-ts-errors

Conversation

@bennypowers
Copy link
Member

@bennypowers bennypowers commented Dec 26, 2022

What I did

futz with the typescript configs and fix some typescript errors in various test files

should unblock release (see https://github.com/patternfly/patternfly-elements/actions/runs/3780052452/jobs/6425817091)

this was cherry-picked from #2283

@bennypowers bennypowers requested a review from zeroedin December 26, 2022 17:01
@changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2022

⚠️ No Changeset found

Latest commit: 870a296

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added tests Related to testing tools Development and build tools labels Dec 26, 2022
@bennypowers bennypowers enabled auto-merge (squash) December 26, 2022 17:04
@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2022

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 22e8eb7
😎 Deploy Preview https://deploy-preview-2284--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Dec 26, 2022
@bennypowers bennypowers requested a review from heyMP December 27, 2022 20:09
@bennypowers bennypowers disabled auto-merge December 29, 2022 21:31
@bennypowers bennypowers merged commit d4793ca into main Dec 29, 2022
@bennypowers bennypowers deleted the chore/fix-ts-errors branch December 29, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed tests Related to testing tools Development and build tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants