Skip to content

Conversation

@eyevana
Copy link
Contributor

@eyevana eyevana commented Mar 28, 2023

Closes #2453

What I did

  1. Fixed get started CTA color on hover

Testing Instructions

  1. Open the docs link and hover over the get started CTA (also set focus + hover in dev tools) and verify the text color is white.

Notes to Reviewers

  1. I don't think we're using pfe-cta in the docs anymore? Should we remove those custom variable overrides?

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

⚠️ No Changeset found

Latest commit: 60201d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eyevana eyevana requested a review from zeroedin March 28, 2023 18:38
@github-actions github-actions bot added work in progress POC / Not ready for review doc AT passed Automated testing has passed labels Mar 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 6576850
😎 Deploy Preview https://deploy-preview-2457--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers bennypowers changed the title fix: set text color to white on hover docs: set text color to white on hover Mar 28, 2023
@eyevana eyevana marked this pull request as ready for review March 29, 2023 00:07
@brianferry
Copy link
Collaborator

image

Now I'm not seeing any text when tab-focused & hovered, I think the focus should be the same color as the hover? color: var(--pf-theme--color--accent, #0066cc);

@eyevana
Copy link
Contributor Author

eyevana commented Mar 29, 2023

@brianferry check out the latest. Should be fixed now. Thank you! :)

@brianferry
Copy link
Collaborator

This looks good to me!

@zeroedin zeroedin merged commit 3e9fafb into main Mar 29, 2023
@zeroedin zeroedin deleted the fix/get-started-cta branch March 29, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed work in progress POC / Not ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug][docs] Get Started CTA on homepage inaccessible focus+hover state

4 participants