Skip to content

Conversation

@zeroedin
Copy link
Contributor

@zeroedin zeroedin commented Jun 15, 2023

What I did

  1. Fixed style regression on tabs when a slotted icon is not present

Testing Instructions

  1. View Deploy preview

Notes to Reviewers

  1. Tabs without icons should not have extra space, the icon slot should be hidden

@zeroedin zeroedin added the bug label Jun 15, 2023
@zeroedin zeroedin self-assigned this Jun 15, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

🦋 Changeset detected

Latest commit: 7bd354d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added styles An issue or PR pertaining only to CSS/Sass AT passed Automated testing has passed labels Jun 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 4860af2
😎 Deploy Preview https://deploy-preview-2519--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers bennypowers enabled auto-merge (squash) June 16, 2023 13:18
@bennypowers bennypowers merged commit 78f3333 into main Jun 16, 2023
@bennypowers bennypowers deleted the fix/tabs/icon-style-regression branch June 16, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed bug ready to merge styles An issue or PR pertaining only to CSS/Sass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants