US188751 Hide-show component

[starryeyez024]

This component toggles between the tabs and the accordion components depending on the space available. If the space is smaller than 768px, the accordion is rendered; otherwise, the tabs are rendered.

[starryeyez024]

@chrisdo1 @castastrophe I'm getting this error in storybook - are you?

Cannot find module "lorem-ipsum"
    
      Error: Cannot find module "lorem-ipsum"
    at webpackMissingModule (http://localhost:9001/static/preview.bundle.js:35670:77)
    at Object. (http://localhost:9001/static/preview.bundle.js:35670:165)
    at Object. (http://localhost:9001/static/preview.bundle.js:35727:30)
    at __webpack_require__ (http://localhost:9001/static/preview.bundle.js:679:30)
    at fn (http://localhost:9001/static/preview.bundle.js:89:20)
    at webpackContext (http://localhost:9001/static/preview.bundle.js:32521:9)
    at http://localhost:9001/static/preview.bundle.js:30133:12
    at Array.forEach ()
    at loadStories (http://localhost:9001/static/preview.bundle.js:30128:14)
    at ConfigApi._renderMain (http://localhost:9001/static/preview.bundle.js:31107:20)
    
  
ERROR in ./elements/pfe-hide-show/pfe-hide-show.story.js
Module not found: Error: Can't resolve 'lorem-ipsum' in '/Users/ktotten/Sites/rhelements/elements/pfe-hide-show'
ERROR in ./elements/pfe-tabs/pfe-tabs.story.js
Module not found: Error: Can't resolve 'lorem-ipsum' in '/Users/ktotten/Sites/rhelements/elements/pfe-tabs'

[chrisdo1]

@chrisdo1 @castastrophe I'm getting this error in storybook - are you?

Cannot find module "lorem-ipsum"
    
      Error: Cannot find module "lorem-ipsum"
    at webpackMissingModule (http://localhost:9001/static/preview.bundle.js:35670:77)
    at Object. (http://localhost:9001/static/preview.bundle.js:35670:165)
    at Object. (http://localhost:9001/static/preview.bundle.js:35727:30)
    at __webpack_require__ (http://localhost:9001/static/preview.bundle.js:679:30)
    at fn (http://localhost:9001/static/preview.bundle.js:89:20)
    at webpackContext (http://localhost:9001/static/preview.bundle.js:32521:9)
    at http://localhost:9001/static/preview.bundle.js:30133:12
    at Array.forEach ()
    at loadStories (http://localhost:9001/static/preview.bundle.js:30128:14)
    at ConfigApi._renderMain (http://localhost:9001/static/preview.bundle.js:31107:20)
    
  
ERROR in ./elements/pfe-hide-show/pfe-hide-show.story.js
Module not found: Error: Can't resolve 'lorem-ipsum' in '/Users/ktotten/Sites/rhelements/elements/pfe-hide-show'
ERROR in ./elements/pfe-tabs/pfe-tabs.story.js
Module not found: Error: Can't resolve 'lorem-ipsum' in '/Users/ktotten/Sites/rhelements/elements/pfe-tabs'

@starryeyez024 Yep, I got the same error. Here's what I did:

1. deleted node modules in the pfe root
2. ran npm install again
3. you'll probably see an error like this one: 404 Not Found: @pfelements/pfelement@1.0.0-prerelease.7 which you can safely ignore
4. ran npm run bootstrap
5. ran npm install from inside the number web component root.

[castastrophe]

@chrisdo1 The copyright is no longer needed at the top of the src/pfe-hide-show.js file. You can delete the entire comment here.

[chrisdo1]

@castastrophe I have removed the comment.

[castastrophe]

Looks good! I added a couple minor issues that we can go back and look at later.

[starryeyez024]

@chrisdo1 ^

[chrisdo1]

@starryeyez024 fixed. Thanks!

[kylebuch8]

Luddite Gary Technological Misbeliever