Conversation
🦋 Changeset detectedLatest commit: 1e43b7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
work in progress
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bennypowers
force-pushed
the
feat/tools/eslint-flat-config
branch
from
a3526f4 to
2b18f99
Compare
github-actions
bot
added
doc
functionality
assertion labels go in the expect call, not in the getComputedStyle call
tab to chip group instead of calling focus on it this may indicate breakage in delegatesFocus
| }); | ||
|
|
||
| describe('keyboard navigating with arrow keys to third chip and pressing enter', function() { | ||
| beforeEach(() => element.focus()); |
There was a problem hiding this comment.
@nikkimk this was the only change I was able to ID that might have practical significance. tests fail on this branch with .focus on the chip group, and in my investigation, i found that this assertion failed because the activeElement remained <body> the whole time.
this fix, using playwright to simulate a Tab key press, rather than calling .focus() fixes the test.
I suspect, but can't yet confirm, that this is because of a bump in playwright version in this PR.
In any event, please confirm that this change doesn't represent breakage for users.
1 participant
What I did
Testing Instructions
npm run lintNotes to Reviewers
I recommend using the "hide whitespace" option in the github diff view