fix(tools): restore missing files in create-element package#2970
Open
bennypowers wants to merge 1 commit intomainfrom
Open
fix(tools): restore missing files in create-element package#2970bennypowers wants to merge 1 commit intomainfrom
bennypowers wants to merge 1 commit intomainfrom
Conversation
…shed package Closes #2967 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: c6a549f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(tools): restore missing files in create-element package"
} |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.npmignoretotools/create-element/so that thefilesfield inpackage.jsoncontrols what gets published, rather than being filtered by.gitignore.gitignorepatterns even whenfilesis set, which caused compiled output (main.js,main.d.ts,generator/) to be excluded from the 1.0.5 tarballCloses #2967
Test plan
cd tools/create-element && npm pack --dry-runshows 17 files includingmain.js,main.d.ts, andgenerator/*.jsnpm run newworks downstream after publishing