Skip to content

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Jan 28, 2019

Incorporate a few new features into the card layout:

  • Support for background color in the header region
  • Update variable names and add additional hooks
  • Add overflow setting to allow children in slots to fill the card
  • Add storybook support for self-closing tags (img, br, hr, etc.)
  • Updates border-radius to 3px globally

@castastrophe castastrophe changed the title Card feature updates WIP: Card feature updates Jan 28, 2019
@castastrophe castastrophe changed the title WIP: Card feature updates Card feature updates Jan 29, 2019
@starryeyez024
Copy link
Member

starryeyez024 commented Feb 18, 2019

@castastrophe after running npm run clean && npm install, the command npm run storybook returns an error at localhost:9001 that says:
Story of "Call to action" named "pfe-cta" already exists

@starryeyez024
Copy link
Member

@starryeyez024 starryeyez024 added the needs code updates Code updates have been requested. label Mar 12, 2019
@castastrophe castastrophe added ready: code review Ready for code review! and removed work in progress POC / Not ready for review labels May 16, 2019
chrisdo1
chrisdo1 previously approved these changes May 23, 2019
Copy link
Contributor Author

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates look good 👍

@castastrophe castastrophe added ready to merge and removed ready: code review Ready for code review! labels May 23, 2019
@kylebuch8
Copy link
Contributor

Alright. I think we're finally good to go with card. Just a heads up, we're making a few changes to the PFElement base class.

In the connectedCallback(), we're adding this.setAttribute("pfelement", "") and then in the _mapSchemaToSlots method, we're using this.setAttribute(has_${slot}, "") if the slot exists.

This is all done because set classes might be fragile.

View this comment to see what helped guide us to these changes.

Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Licking Gorilla Tastes Mango

@kylebuch8 kylebuch8 merged commit bf8790f into master May 24, 2019
@kylebuch8 kylebuch8 deleted the pfe-card-feature-updates branch May 24, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants