Skip to content

chore: improve review-api skill, lit template quoted attributes#3147

Merged
bennypowers merged 1 commit into
staging/pfv6from
chore/review-api-quote-attributes
May 13, 2026
Merged

chore: improve review-api skill, lit template quoted attributes#3147
bennypowers merged 1 commit into
staging/pfv6from
chore/review-api-quote-attributes

Conversation

@zeroedin
Copy link
Copy Markdown
Collaborator

What I did

  1. Add rule to check for quoted attributes in lit templates

Testing Instructions

Notes to Reviewers

@zeroedin zeroedin requested a review from bennypowers May 13, 2026 17:20
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

⚠️ No Changeset found

Latest commit: d944b32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "chore: improve review-api skill, lit template quoted attributes"
}

@github-actions github-actions Bot added the AT passed Automated testing has passed label May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 0b5a1b4
😎 Deploy Preview https://deploy-preview-3147--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 0b5a1b4: Report

Copy link
Copy Markdown
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lucidly greeted textual middlewords

@bennypowers bennypowers merged commit 98a4efc into staging/pfv6 May 13, 2026
12 checks passed
@bennypowers bennypowers deleted the chore/review-api-quote-attributes branch May 13, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants