adding a mutationobserver to pfe-content-set#406
Merged
Conversation
kylebuch8
added
ready: branch testing
castastrophe
suggested changes
May 23, 2019
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
Initial review - I noticed that in rewriting a lot of my comments were removed but they were not replaced. Can you add back a few descriptive comments?
Adding most of the comments back but left some of the self-explanatory comments out.
Contributor
Author
|
@castastrophe In commit dbbc1d3 I added most of the comments back. I left just a few of the self explanatory comments out. |
Contributor
|
Somehow prettier was not run on |
6 tasks
…fly/patternfly-elements into pfe-content-set-mutationobserver
starryeyez024
removed
ready: branch testing
…fly/patternfly-elements into pfe-content-set-mutationobserver
mwcz
previously approved these changes
Oct 25, 2019
Contributor
mwcz
left a comment
mwcz
left a comment
There was a problem hiding this comment.
Look! Grotesque Tabs Mutation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.