Skip to content

Conversation

@markcaron
Copy link
Contributor

No description provided.

@markcaron markcaron requested a review from kylebuch8 May 8, 2019 17:55
@castastrophe
Copy link
Contributor

@markcaron I wrote some tests for you, created a schema, and generated the storybook file for you for this component if you would like: https://github.com/patternfly/patternfly-elements/pull/412/files?file-filters%5B%5D=.html&file-filters%5B%5D=.js&file-filters%5B%5D=.md&file-filters%5B%5D=.scss

I also have a small suggestion for the styles to give it better fallback experience for older browsers.

Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local Gorilla Tribunal Meetup

@kylebuch8 kylebuch8 merged commit 84dbf03 into master May 22, 2019
@kylebuch8 kylebuch8 deleted the pfe-docs-status branch May 22, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants