Pfe docs status #408
Merged
Pfe docs status #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castastrophe
reviewed
May 8, 2019
castastrophe
reviewed
May 8, 2019
castastrophe
reviewed
May 8, 2019
castastrophe
reviewed
May 8, 2019
castastrophe
reviewed
May 8, 2019
Contributor
|
@markcaron I wrote some tests for you, created a schema, and generated the storybook file for you for this component if you would like: https://github.com/patternfly/patternfly-elements/pull/412/files?file-filters%5B%5D=.html&file-filters%5B%5D=.js&file-filters%5B%5D=.md&file-filters%5B%5D=.scss I also have a small suggestion for the styles to give it better fallback experience for older browsers. |
A few enhancements for pfe-page-status
kylebuch8
approved these changes
May 22, 2019
Contributor
kylebuch8
left a comment
kylebuch8
left a comment
There was a problem hiding this comment.
Local Gorilla Tribunal Meetup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.