Conversation
mwcz
reviewed
Jul 16, 2018
|
|
||
| function timer() { | ||
| document.getElementById("realtime").setAttribute("datetime", new Date()); | ||
| window.requestAnimationFrame(timer); |
Contributor
There was a problem hiding this comment.
I think this would be better as a setInterval every second. As written it's equivalent to a setInterval every 16 milliseconds; all that rAF adds is synchronizing the interval to match the screen's refresh rate.
Contributor
Author
There was a problem hiding this comment.
But rAF makes sure that the timer is super accurate.
Contributor
There was a problem hiding this comment.
It seems like overkill to me but in a story it's not that big a deal. If it were in the component itself I'd urge setInterval or a throttle within rAF.
Contributor
Author
There was a problem hiding this comment.
Ok, let's roll with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.