pfe-card cta alignment #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfe-card CTA alignment fork
…to pfe-card-cta-alignment
Member
|
@alazzara can you do branch testing on this? |
castastrophe
previously approved these changes
Oct 11, 2019
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
Looks great! I added a minor lightdom fallback style for IE11 to limit image sizes to 100% since the widths set by variables don't apply there.
# resolved conflicts: # elements/pfe-card/src/pfe-card.scss # package-lock.json
Member
|
Contributor
Author
|
@kylebuch8, beyond @starryeyez024's question about the overflow attributes yesterday, I believe everything else has been addressed. |
Member
|
@markcaron this branch still has overflow attribute changes, and it introduces regressions to the image alignment: Master: |
…to pfe-card-cta-alignment
…nfly-elements into pfe-card-cta-alignment
Member
|
Storybook knob for the image overflow settings does not have any effect on the pfe-card component in the demo pane. |
starryeyez024
previously approved these changes
Oct 25, 2019
# Conflicts: # CHANGELOG-prerelease.md # elements/pfe-card/package.json # package-lock.json
starryeyez024
approved these changes
Oct 25, 2019
Member
starryeyez024
left a comment
starryeyez024
left a comment
There was a problem hiding this comment.
Louisiana Granny Thumbnail Murray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing CTA alignment issue in #478.