Skip to content

Add automatic Sass globbing to pfe-sass#565

Merged
castastrophe merged 22 commits intomasterfrom
sass-globbing-support
Oct 11, 2019
Merged

Add automatic Sass globbing to pfe-sass#565
castastrophe merged 22 commits intomasterfrom
sass-globbing-support

Conversation

@castastrophe
Copy link
Copy Markdown
Contributor

@castastrophe castastrophe commented Oct 8, 2019

Add automatic Sass globbing to pfe-sass

What has changed and why

Summarize files edited as part of this MR along with a brief description of what was changed/why.

  • Add build tasks for pfe-sass
  • Move glob files to being dynamically built
  • Add maps

Testing instructions

Be sure to include detailed instructions on how your update can be tested by another developer.

  • npm run demo
  • Ensure no visual regressions, no errors in console

Requirements

Your repository infrastructure updates should work for at least:

  • Node v8.x
  • NPM v7.x

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Confirm no regressions in compiled assets
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demo'd?
  • Did you update the CHANGELOG.md file with a summary of this update?

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@castastrophe
Copy link
Copy Markdown
Contributor Author

@starryeyez024 Decided it was easier to pull out the sass globbing updates from the broadcast branch into it's own PR for easier code review and better scoping. This branch just contains the addition of automatic sass globbing, no broadcast updates.

@castastrophe castastrophe added feature New feature or request ready: branch testing Test the component from a user-perspective. Try to break it! ready: code review Ready for code review! labels Oct 8, 2019
Comment thread elements/pfe-sass/package.json Outdated
Comment thread elements/pfe-sass/gulpfile.js
starryeyez024
starryeyez024 previously approved these changes Oct 9, 2019
Copy link
Copy Markdown
Member

@starryeyez024 starryeyez024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple doc notes, code (minus gulp tasks) LGTM

Comment thread elements/pfe-sass/README.md Outdated
Comment thread elements/pfe-sass/README.md
Comment thread package.json Outdated
@castastrophe castastrophe added ready to merge and removed ready: branch testing Test the component from a user-perspective. Try to break it! ready: code review Ready for code review! labels Oct 11, 2019
@starryeyez024 starryeyez024 self-assigned this Oct 11, 2019
Copy link
Copy Markdown
Member

@starryeyez024 starryeyez024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lyrics: Get Taxi Money

@castastrophe castastrophe merged commit d4600dd into master Oct 11, 2019
@castastrophe castastrophe deleted the sass-globbing-support branch October 11, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants