Add automatic Sass globbing to pfe-sass#565
Merged
castastrophe merged 22 commits intomasterfrom Oct 11, 2019
Merged
Conversation
added 11 commits
October 7, 2019 19:43
Contributor
Author
|
@starryeyez024 Decided it was easier to pull out the sass globbing updates from the broadcast branch into it's own PR for easier code review and better scoping. This branch just contains the addition of automatic sass globbing, no broadcast updates. |
castastrophe
commented
Oct 8, 2019
starryeyez024
previously approved these changes
Oct 9, 2019
Member
starryeyez024
left a comment
There was a problem hiding this comment.
Couple doc notes, code (minus gulp tasks) LGTM
chrisdo1
reviewed
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add automatic Sass globbing to pfe-sass
What has changed and why
Summarize files edited as part of this MR along with a brief description of what was changed/why.
Testing instructions
Be sure to include detailed instructions on how your update can be tested by another developer.
npm run demoRequirements
Your repository infrastructure updates should work for at least:
Ready-for-merge Checklist
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!