pfe-cta: Add wind variant styles for "brick" design#566
Merged
Conversation
Member
added 4 commits
October 15, 2019 17:36
…ments into US228968-brick-pfe-cta
…ded MR to changelog, updated documentation to show variant option
LyndseyR
added
ready: branch testing
castastrophe
suggested changes
Oct 21, 2019
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
A couple notes about sass functions and mixins to use.
castastrophe
added
needs code updates
Contributor
|
One last note - needs the README updated to reflect the new setting. |
added 2 commits
October 21, 2019 11:50
castastrophe
previously approved these changes
Oct 21, 2019
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
I applied code review changes since Lyndsey is out on PTO
…documentation; support button if necessary
…ta storybook to render attributes correctly
castastrophe
changed the title
castastrophe
changed the title
added 3 commits
October 22, 2019 15:41
starryeyez024
previously approved these changes
Oct 24, 2019
Member
There was a problem hiding this comment.
browser testing: https://rally1.rallydev.com/#/270861059696d/detail/testcaseresult/343691073072?fdp=true
Logic Gained Too Much! (besides merge conflicts on changelog / package.json)
…to US228968-brick-pfe-cta
castastrophe
added
styles
starryeyez024
approved these changes
Oct 24, 2019
Member
starryeyez024
left a comment
starryeyez024
left a comment
There was a problem hiding this comment.
Lower Gaming Third Macedonia
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pfe-cta update | add new brick CTA styles
What has changed and why
Summarize files edited as part of this MR along with a brief description of what was changed/why.
Testing instructions
Be sure to include detailed instructions on how your update can be tested by another developer.
US228968-brick-pfe-cta<pfe-cta pfe-priority="secondary"><pfe-cta pfe-priority="secondary" pfe-variant="wind">Browser requirements
Your component should work in all of the following environments:
Your repository infrastructure updates should work for at least:
Ready-for-merge Checklist
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!