Skip to content

Fix build tasks and packages for publication#594

Merged
castastrophe merged 8 commits intomasterfrom
fix-build-tasks
Oct 29, 2019
Merged

Fix build tasks and packages for publication#594
castastrophe merged 8 commits intomasterfrom
fix-build-tasks

Conversation

@castastrophe
Copy link
Copy Markdown
Contributor

@castastrophe castastrophe commented Oct 28, 2019

Fix build tasks and packages for publication

  • During last prerelease we ran into some issues with how the files array was defined which conflicted with the needs of the build tasks; this branch updates the build tasks and packages.
    • Packages point to dist directory location for files and the files array contains only the dist directory
    • Build tasks use a default set of asset names with an optional hook for assets in the pfelement object inside the package.json

Testing instructions

Be sure to include detailed instructions on how your update can be tested by another developer.

  1. Pull down the latest from the branch and run a build.
  2. Validate that the expected assets for that component to work in production appear in the dist directory.
  3. There should be no errors in the console.

Your repository infrastructure updates should work for at least:

  • Node v8.x
  • NPM v7.x

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demo'd and the design review approved?
  • Did you update the CHANGELOG.md file with a summary of this update?

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@castastrophe castastrophe requested a review from mwcz October 28, 2019 22:26
Comment thread docs/content/develop/step-5.md Outdated
Comment thread docs/content/develop/step-5.md
Comment thread docs/content/develop/step-5.md Outdated
Comment thread docs/content/develop/step-5.md
Comment thread docs/content/develop/step-5.md Outdated
Comment thread docs/content/develop/step-5.md Outdated
Comment thread docs/content/develop/step-5.md
Comment thread docs/content/develop/step-5.md Outdated
castastrophe and others added 5 commits October 29, 2019 12:59
Co-Authored-By: Michael Clayton <mwc@clayto.com>
Co-Authored-By: Michael Clayton <mwc@clayto.com>
Co-Authored-By: Michael Clayton <mwc@clayto.com>
Co-Authored-By: Michael Clayton <mwc@clayto.com>
Co-Authored-By: Michael Clayton <mwc@clayto.com>
@mwcz
Copy link
Copy Markdown
Contributor

mwcz commented Oct 29, 2019 via email

Copy link
Copy Markdown
Contributor

@mwcz mwcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loose Gems Thanos Mischief

@castastrophe castastrophe merged commit a4b2c27 into master Oct 29, 2019
@castastrophe castastrophe deleted the fix-build-tasks branch October 29, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants