Fix build tasks and packages for publication#594
Merged
castastrophe merged 8 commits intomasterfrom Oct 29, 2019
Merged
Conversation
added 3 commits
October 28, 2019 17:16
mwcz
requested changes
Oct 29, 2019
Co-Authored-By: Michael Clayton <mwc@clayto.com>
Co-Authored-By: Michael Clayton <mwc@clayto.com>
Co-Authored-By: Michael Clayton <mwc@clayto.com>
Co-Authored-By: Michael Clayton <mwc@clayto.com>
Co-Authored-By: Michael Clayton <mwc@clayto.com>
Contributor
|
Ohhh, I see! Totally, yes, let's defer.
--
Michael Clayton
https://clayto.com
…On October 29, 2019 12:12:21 PM EDT, "[ Cassondra ]" ***@***.***> wrote:
castastrophe commented on this pull request.
> +1. `git status`
+ 1. Check where you are
+2. `git checkout master && git fetch origin && git pull origin`
+ 2. Grab master from origin
+3. `npm run clean`
+ 3. Wipes node_modules directory and deletes any components not in
master
+ 4. what this does:
+ 5. rm -rf node_modules package-lock.json
+ 6. rm -rf node_modules
+4. `git reset --hard && git clean -df`
+ 7. Remove any non-committed files, crufty directories
+5. `npm install`
+ 8. Installs all dependencies fresh
+6. `git checkout -b temp`
+ 9. Create temp branch
I didn't actually make any changes to this file, just migrated it from
step-4 to step-5. Do you mind if we defer updates to this until a
later PR?
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#594 (comment)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build tasks and packages for publication
Testing instructions
Be sure to include detailed instructions on how your update can be tested by another developer.
Your repository infrastructure updates should work for at least:
Ready-for-merge Checklist
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!