Skip to content

Updates to pfelement supporting new compilation approach#601

Merged
kylebuch8 merged 4 commits intomasterfrom
pfelement-css-compilaiton
Nov 4, 2019
Merged

Updates to pfelement supporting new compilation approach#601
kylebuch8 merged 4 commits intomasterfrom
pfelement-css-compilaiton

Conversation

@castastrophe
Copy link
Copy Markdown
Contributor

@castastrophe castastrophe commented Nov 1, 2019

Updates to pfelement supporting new compilation approach

  • The pfelement css assets were not being moved to the dist directory due to the updated compilation tasks, this is being fixed in this branch.

What has changed and why

Summarize files edited as part of this MR along with a brief description of what was changed/why.

  • Renamed pfelement-noscript.css to pfelement--noscript.css
  • Added pfelement.css to the assets list in the pfelement object in the package.json
  • Updated references to and documentation of the --noscript.css file

Testing instructions

Be sure to include detailed instructions on how your update can be tested by another developer.

  1. Run npm run build pfelement, confirm that pfelement.css (minified versions and maps) and pfelement--noscript.css (same) are available in the dist directory.

Your repository infrastructure updates should work for at least:

  • Node v8.x
  • NPM v7.x

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Was this feature demo'd and the design review approved?
  • Did you update the CHANGELOG.md file with a summary of this update?

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

kylebuch8
kylebuch8 previously approved these changes Nov 1, 2019
Copy link
Copy Markdown
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemur Giraffe Tiger Monkey

@castastrophe castastrophe changed the title WIP: Updates to support new compilation approach Updates to pfelement supporting new compilation approach Nov 1, 2019
Copy link
Copy Markdown
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemurs Giraffes Tigers Monkeys

@kylebuch8 kylebuch8 merged commit b2a099d into master Nov 4, 2019
@kylebuch8 kylebuch8 deleted the pfelement-css-compilaiton branch November 4, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants