Updates to pfelement supporting new compilation approach#601
Merged
Updates to pfelement supporting new compilation approach#601
Conversation
kylebuch8
previously approved these changes
Nov 1, 2019
Contributor
kylebuch8
left a comment
There was a problem hiding this comment.
Lemur Giraffe Tiger Monkey
kylebuch8
approved these changes
Nov 4, 2019
Contributor
kylebuch8
left a comment
There was a problem hiding this comment.
Lemurs Giraffes Tigers Monkeys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to pfelement supporting new compilation approach
What has changed and why
Summarize files edited as part of this MR along with a brief description of what was changed/why.
Testing instructions
Be sure to include detailed instructions on how your update can be tested by another developer.
npm run build pfelement, confirm that pfelement.css (minified versions and maps) and pfelement--noscript.css (same) are available in the dist directory.Your repository infrastructure updates should work for at least:
Ready-for-merge Checklist
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!