Merged
Conversation
…ch theme context is invoked by surface colors. Add demo file for this.
… to custom-theme from card demo
starryeyez024
commented
Dec 2, 2019
added 2 commits
December 2, 2019 18:22
LyndseyR
previously approved these changes
Dec 2, 2019
castastrophe
previously approved these changes
Dec 2, 2019
Contributor
castastrophe
left a comment
There was a problem hiding this comment.
Looks great! Just needs a changelog
…/patternfly-elements into DE21128-broadcast-theme-hooks
abfd9bb
Member
Author
|
@castastrophe added! |
kylebuch8
approved these changes
Dec 2, 2019
Contributor
kylebuch8
left a comment
There was a problem hiding this comment.
Lady Gaga... Thy Manners!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://localhost:8000/elements/pfe-card/demo/
What has changed and why
Testing instructions
Be sure to include detailed instructions on how your update can be tested by another developer.
Browser requirements
Your component should work in all of the following environments:
Ready-for-merge Checklist