Skip to content

Set PFE default accent color to red #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Djfaucette merged 6 commits into from
Jan 20, 2020
Merged

Set PFE default accent color to red #684

Djfaucette merged 6 commits into from
Jan 20, 2020

Conversation

@starryeyez024
Copy link
Member

@starryeyez024 starryeyez024 commented Jan 20, 2020 •
edited
Loading

  • Link(s) to demo pages where this element can be viewed:

What has changed and why

This PR updates orange to red to bring in official RH colors, but also because IE11 doesn't inherit CSS vars so the CTA primary links are orange on prod in IE11. This fixes that.

Testing instructions

Be sure to include detailed instructions on how your update can be tested by another developer.

  1. View a page with primary CTAs in IE11. They should be red instead of orange.
  2. View the pfe-badge component to ensure colors look the same as they do here https://patternfly.github.io/patternfly-elements/demo/?path=/story/badge--pfe-badge

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 60.7.2 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Galaxy S9 Firefox
  • iPhone X Safari
  • iPad Pro Safari
  • Pixel 3 Chrome

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Did browser testing pass?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demo'd and the design review approved?
  • Did you update the CHANGELOG.md file with a summary of this update?

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@starryeyez024 starryeyez024 changed the title Set PFE default accent color to red #596 Set PFE default accent color to red Jan 20, 2020
ryanissamson
ryanissamson previously approved these changes Jan 20, 2020
View reviewed changes
kylebuch8
kylebuch8 previously approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned Guitar, Totally Mesmerized.

@starryeyez024
Copy link
Member Author

starryeyez024 commented Jan 20, 2020

ie11
image

safari
image

Edge 18
image

Edge 17
image

UC browser
image

@starryeyez024
Merge branch 'master' into update-accent-color-red
886be52 
# Conflicts:
#	examples/index.html
@Djfaucette
Copy link
Contributor

Djfaucette commented Jan 20, 2020

Liver great taking mezcal

@starryeyez024 starryeyez024 requested review from Djfaucette and ThatGuyCND and removed request for LyndseyR January 20, 2020 21:01
@Djfaucette
Copy link
Contributor

Djfaucette commented Jan 20, 2020

...Can I approve now?

Djfaucette
Djfaucette approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@Djfaucette Djfaucette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to monkeys

ThatGuyCND
ThatGuyCND approved these changes Jan 20, 2020
View reviewed changes
Copy link

@ThatGuyCND ThatGuyCND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Djfaucette Djfaucette merged commit 36ceb13 into master Jan 20, 2020
kylebuch8
kylebuch8 approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lego Ghost Translucent Mystery

@starryeyez024 starryeyez024 deleted the update-accent-color-red branch February 12, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylebuch8 kylebuch8 kylebuch8 approved these changes

@ThatGuyCND ThatGuyCND ThatGuyCND approved these changes

@Djfaucette Djfaucette Djfaucette approved these changes

+1 more reviewer

@ryanissamson ryanissamson ryanissamson left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@starryeyez024 @Djfaucette @kylebuch8 @ThatGuyCND @ryanissamson