fix reference error in pfe-navigation when slot is missing #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mwcz There's a lot of formatting updates, can you help point me to the part of the code that is updated? |
castastrophe
previously approved these changes
Jan 23, 2020
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
👍 One suggestion for the changelog since we know what the release tag would be.
Contributor
|
I tested the search and the language slots and neither throws the error anymore when commented out. |
Co-Authored-By: [ Cassondra ] <castastrophe@users.noreply.github.com>
castastrophe
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why
pfe-navigation contained a reference to a variable that may not exist. The code was already doing some defensive checks of that kind, but one edge case was missed. This PR adds the edge case.
See commit 27aa87d to view that change.
I'm calling out the exact commit because this PR also runs prettier to format pfe-navigation which generated a lot of excess diffs. Somehow this element hasn't been formatted by the automatic formatter already.
Testing instructions
Open
elements/pfe-navigation/demo/index.html, and comment out the<pfe-navigation-item>that hasslot="search".View the pfe-navigation demo page and confirm that the JS error is no longer in the console.
Ready-for-merge Checklist