Skip to content

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Jan 29, 2020

Add events to the generator

  • Add an events query to the generator

Testing instructions

Be sure to include detailed instructions on how your update can be tested by another developer.

  1. Run 'npm run new'

? What would you like to create? content
? Element name (i.e. pfe-card) pfe-foo
? Author name castastrophe
? Do you want to use Sass with this element? Yes
? Do want to use existing Sass dependencies? pfe-sass
? Describe the element's purpose or goal. Do a thing.
? List any attributes for the element, separated by commas (i.e., color, priority) one,two
? List any named slots for the element, separated by commas (i.e., header, footer) three,four
? List any events you want registered for the element, separated by commas (i.e., change, click) click,tab

  1. Check the README and pfe-foo.js for content specific to the events you entered.

Your repository infrastructure updates should work for at least:

  • Node v8.x
  • NPM v7.x

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demo'd and the design review approved?
  • Did you update the CHANGELOG.md file with a summary of this update?

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@castastrophe castastrophe marked this pull request as ready for review February 20, 2020 18:57
@castastrophe castastrophe requested a review from mwcz February 20, 2020 18:58
@castastrophe castastrophe added the feature New feature or request label Mar 4, 2020
@castastrophe castastrophe added ready: branch testing Test the component from a user-perspective. Try to break it! ready: code review Ready for code review! labels Mar 4, 2020
Copy link
Contributor

@eyevana eyevana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked like a charm! :)

@castastrophe castastrophe merged commit fdfd6fc into master Mar 10, 2020
@castastrophe castastrophe deleted the feat-add-events-generator branch March 10, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request ready: branch testing Test the component from a user-perspective. Try to break it! ready: code review Ready for code review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants