feat: Adding ability to configure the localhost domain #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesruv
force-pushed
the
add-configurable-localhost
branch
from
f0e24a7 to
18829e4
Compare
kylebuch8
reviewed
Jan 30, 2020
| "decomment": "^0.9.1", | ||
| "del": "^3.0.0", | ||
| "dialog-polyfill": "^0.4.10", | ||
| "generator-pfelement": "^1.4.0", |
Contributor
There was a problem hiding this comment.
@wesruv I don't think we want to remove the generator as a dependency.
Adding dotenv package Defaulting localhost to 'localhost', but .env file can override that Added example .env file Ignoring .env file
wesruv
force-pushed
the
add-configurable-localhost
branch
from
18829e4 to
8448142
Compare
kylebuch8
approved these changes
Feb 6, 2020
Contributor
kylebuch8
left a comment
kylebuch8
left a comment
There was a problem hiding this comment.
Lobby Guest's Talisman Matures
Contributor
Author
|
@kylebuch8 it looks like all of the netlify stuff is still outstanding for some reason? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding dotenv package
Defaulting localhost to 'localhost', but .env file can override that
Added example .env file
Ignoring .env file
Testing instructions
Be sure to include detailed instructions on how your update can be tested by another developer.
npm ito get new additions to build.npm startwithout adding a.envfile, should provide a server athttp://localhost:8000/examples.env.exampleas.envand add a domain of your choosingnpm startand you should gethttp://YOURHOSTNAME:8000/examples