feat: Update pfe-content-set to accept custom container queries#710
Merged
starryeyez024 merged 25 commits intomasterfrom Feb 12, 2020
Merged
Conversation
…custom-container-queries
LyndseyR
reviewed
Feb 3, 2020
Per allotted content area within pfe-band on tablets, which is 704px
…ner-queries' of https://github.com/patternfly/patternfly-elements into US231294-Update-pfe-content-set-to-accept-custom-container-queries Getting latest updates made to branch and pulling them into local
… a max-width not fixed width. This broke testing when you shrunk the window.
castastrophe
suggested changes
Feb 7, 2020
Contributor
castastrophe
left a comment
There was a problem hiding this comment.
Looks great! Love this update. Needs a changelog.
…custom-container-queries
…ner-queries' of https://github.com/patternfly/patternfly-elements into US231294-Update-pfe-content-set-to-accept-custom-container-queries Pull latest into branch
Contributor
castastrophe
left a comment
There was a problem hiding this comment.
A couple small notes for the demo page
…ner-queries' of https://github.com/patternfly/patternfly-elements into US231294-Update-pfe-content-set-to-accept-custom-container-queries Update branch with latest in gitlab
starryeyez024
previously approved these changes
Feb 10, 2020
Member
starryeyez024
left a comment
There was a problem hiding this comment.
Late? Gimme Ten Minutes
Member
|
@castastrophe this PR is stuck on your requested changes, can you approve when you have a moment? Thx! |
castastrophe
suggested changes
Feb 11, 2020
…custom-container-queries
starryeyez024
previously approved these changes
Feb 12, 2020
…custom-container-queries
castastrophe
previously approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update pfe-content-set to accept custom container queries
Discovery doc:
Sandbox link:
What has changed and why
Testing instructions
Test cases:
a. And I reload the page at window size 300, i expect that
i. The content set should become accordions
b. And I reload the page at window size 550, i expect that
i. The content set should become tabs
a. And I reload the page at window size 800, i expect that
i. The content set should become accordions
b. And I reload the page at window size 1000, i expect that
i. The content set should become tabs
a. And I reload the page at window size 600, i expect that
i. The content set should become accordions
b. And I reload the page at window size 800, i expect that
i. The content set should become tabs
a. with a value of 400 after the page has loaded
i. The content set should become accordions
b. with a value of 650 after the page has loaded
i. The content set should become tabs
Edge case:
1. Test using px and no px in the value of pfe-breakpoint
Browser requirements
Your component should work in all of the following environments:
Ready-for-merge Checklist
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!