Skip to content

Adding bullseye back and fixing the grid gutters#76

Merged
kylebuch8 merged 2 commits intomasterfrom
rh-layouts-story-bullseye
Jul 24, 2018
Merged

Adding bullseye back and fixing the grid gutters#76
kylebuch8 merged 2 commits intomasterfrom
rh-layouts-story-bullseye

Conversation

@kylebuch8
Copy link
Copy Markdown
Contributor

Fixes #75

@mwcz
Copy link
Copy Markdown
Contributor

mwcz commented Jul 23, 2018

The demo page for this rh-layouts looks completely different than the other demo pages. Is this one a sign of where all the others are headed?

@kylebuch8
Copy link
Copy Markdown
Contributor Author

@markcaron - Can you comment on the styling of the demo page?

@markcaron
Copy link
Copy Markdown
Contributor

The demo in Storybook?

I had to adjust the background so that the grid system (its columns) were evident. We should look to make them more consistent in future version, but it's not necessarily the direction we're going.

@mwcz
Copy link
Copy Markdown
Contributor

mwcz commented Jul 24, 2018

@markcaron I don't think there is a Storybook story for rh-layouts. I was asking about the demo page at elements/rh-layouts/demo/index.html. It was edited in this PR which is the only reason I thought to ask.

I just noticed that the demo page looks very different from all the other demo pages and would like to have a plan for convergence. No need to solve it here, though.

Copy link
Copy Markdown
Contributor

@mwcz mwcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lectures Grapefruit To Music

@mwcz
Copy link
Copy Markdown
Contributor

mwcz commented Jul 24, 2018

The changes look good to me, but I don't feel confident reviewing the sass.

@kylebuch8 kylebuch8 merged commit 8cd38c6 into master Jul 24, 2018
@kylebuch8 kylebuch8 deleted the rh-layouts-story-bullseye branch July 24, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants