-
Notifications
You must be signed in to change notification settings - Fork 106
fix: Add a warning about updating the on attribute before upgrade #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ments into fix-add-warning-on-attribute
|
@kylebuch8 Update applied! Working great! |
|
@kylebuch8 I updated the storybook instances to show theme support. |
|
@kylebuch8 Reverted the storybook updates and moved them into a separate branch. Prettier is still showing updates to the .storybook files but I can't undo that at this point. |
kylebuch8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loans Get The Money

What has changed and why
Summarize files edited as part of this MR along with a brief description of what was changed/why.
onattributeonattribute inside the pfe-content-setTesting instructions
Be sure to include detailed instructions on how your update can be tested by another developer.
pfe-content-setdemo page to add theon="light"attribute on thepfe-content-setandpfe-ctatags. Add an ID to one of the tags.npm install && npm run start pfe-accordion.Ready-for-merge Checklist
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!