Issue 839 pfe tabs history firefox #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tested in:
IE11 note(s):
|
Contributor
|
@todo note to go back and make this test page easier to use on mobile:
|
castastrophe
previously approved these changes
Apr 27, 2020
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
@kylebuch8 Just needs a...drumroll CHANGELOG! Then it's approved 👍
starryeyez024
previously approved these changes
Apr 27, 2020
Member
starryeyez024
left a comment
starryeyez024
left a comment
There was a problem hiding this comment.
Lately, Groceries Travel to Me
castastrophe
dismissed stale reviews from starryeyez024 and themself
via
36eeacf
castastrophe
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
QUERY + HASH | If I load this URL in Firefox https://deploy-preview-841--happy-galileo-ea79c4.netlify.app/elements/pfe-tabs/demo/hash.html?tabs=tab-2#tab-heading
a) I expect the set of tabs to be visible at the top of the screen
b) I expect tab adding command for new RHElement using generator-rhelement #2 should be active, and the focus state should be on the heading "Set of Tabs".
c) When I press the "tab" key, I expect the focus state to move to tab 2.
d) When i press the right arrow key, I expect the focus state and the active style to move to tab 3
e) If I click the TOC link for heading one, I expect the page to smooth scroll to the heading one at the top of the page.
f) If I click the TOC link for heading three, I expect the page to smooth scroll to the heading three at the bottom of the page.
QUERY ONLY | If I load this URL in Firefox https://deploy-preview-841--happy-galileo-ea79c4.netlify.app/elements/pfe-tabs/demo/hash.html?tabs=tab-2
a) I expect the page should be at the natural scroll position (top of page)
b) When I scroll down to the tab set, I expect tab adding command for new RHElement using generator-rhelement #2 to be active
c) When I press the "tab" key, I expect the focus state to on the table of contents (the first items in the DOM)
HASH ONLY | If I load this URL in Firefox https://deploy-preview-841--happy-galileo-ea79c4.netlify.app/elements/pfe-tabs/demo/hash.html#three
a) I expect the page to be at the heading three
b) When I press the "tab" key, I expect the focus state to move to "random link three”