-
Notifications
You must be signed in to change notification settings - Fork 106
Reduce CTA arrow spacing, bring closer to text #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@starryeyez024 Can you add a changelog when you get a chance? |
castastrophe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need changelog fixed
castastrophe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, ready to merge after browser testing and designer sign-off. Probs don't need a demo for this though :D
Seems to be based on fractional units?
castastrophe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great! 👍
Without theme:

With RH theme:

Design spec
Testing instructions
Ready-for-merge Checklist
Check off items as they are completed. Feel free to delete items if they are not applicable to your PR.