Skip to content

feat: Add a default template for PRs#917

Merged
castastrophe merged 4 commits intomasterfrom
feat-default-pull-request-template
Jul 15, 2020
Merged

feat: Add a default template for PRs#917
castastrophe merged 4 commits intomasterfrom
feat-default-pull-request-template

Conversation

@castastrophe
Copy link
Copy Markdown
Contributor

@castastrophe castastrophe commented Jun 10, 2020

Add a default template for pull requests

What has changed and why

Summarize files edited as part of this MR along with a brief description of what was changed/why.

  • Add a generic pull request template in the .github folder that will load when any new PR is created

Testing instructions

Cannot be tested until this is merged. When a new PR is opened, this template should auto-populate.

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Repository compiles and tests pass.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@castastrophe castastrophe added good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language ready: code review Ready for code review! priority: low Severity level: 3 tools Development and build tools and removed good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language labels Jun 11, 2020
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@castastrophe castastrophe requested a review from kylebuch8 June 30, 2020 14:52
Copy link
Copy Markdown
Member

@starryeyez024 starryeyez024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liftoff Gets The Momentum

@castastrophe castastrophe added ready to merge and removed ready: code review Ready for code review! labels Jul 14, 2020
@castastrophe castastrophe removed the request for review from kylebuch8 July 14, 2020 15:55
@castastrophe castastrophe force-pushed the feat-default-pull-request-template branch from be4ff78 to ab7df95 Compare July 14, 2020 15:55
@castastrophe castastrophe force-pushed the feat-default-pull-request-template branch from e56de5c to 7c35fb8 Compare July 15, 2020 11:28
@castastrophe castastrophe merged commit a413f5e into master Jul 15, 2020
@castastrophe castastrophe deleted the feat-default-pull-request-template branch July 15, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low Severity level: 3 ready to merge tools Development and build tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants