fix: pfe-jump-links offset & updates to demo file#974
Merged
Djfaucette merged 32 commits intomasterfrom Oct 22, 2020
Merged
Conversation
…aphs between panel headings.
castastrophe
added
demo
Djfaucette
reviewed
Jul 10, 2020
| </div> | ||
| <div class="pfe-l-grid__item pfe-m-12-col pfe-m-9-col-on-lg"> | ||
| <pfe-jump-links-panel class="special" pfe-c-scrolltarget="jumplinks1"> | ||
| <pfe-jump-links-panel pfe-c-offset="20" class="special" pfe-c-scrolltarget="jumplinks1"> |
Contributor
There was a problem hiding this comment.
This attribute actually does something, we should leave it. You can also put a css value on the panel --pfe-jump-links-panel--offset. It will read css if it's there, and if both are there it will use the attribute.
Member
Author
There was a problem hiding this comment.
not sure what you mean? I've added it here :)
It's also in the demo CSS; is that duplicative?
| <div style="margin: 0 auto 400px;grid-column-gap: 30px;max-width:1140px;" class="pfe-l-grid"> | ||
| <div class="sticky pfe-l-grid__item pfe-m-12-col pfe-m-3-col-on-lg"> | ||
| <pfe-jump-links-nav id="jumplinks1" sr-text="Page navigation"> | ||
| <pfe-jump-links-nav pfe-c-offset="100" id="jumplinks1" sr-text="Page navigation"> |
Contributor
There was a problem hiding this comment.
pfe-c-offset here doesn't do anything.
starryeyez024
commented
Jul 10, 2020
castastrophe
added
ready: branch testing
Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com>
starryeyez024
changed the title
castastrophe
added
the
functionality
Djfaucette
reviewed
Aug 17, 2020
| display: block; | ||
| position: relative; | ||
| width: 0; | ||
| margin-top: calc( -1 * var(--pfe-jump-links-panel__section--spacer) ); |
Contributor
There was a problem hiding this comment.
@starryeyez024 I'm having trouble getting the height and margin-top styles to tie into the custom properties from the demo.css file. Do lines 2, 8 & 9 look ok?
Member
Author
There was a problem hiding this comment.
added fix for line 2 (no interpolation needed)
starryeyez024
commented
Oct 7, 2020
castastrophe
changed the title
Contributor
|
@starryeyez024 Can you take a look at why the CI is failing? |
Contributor
|
Lazarra good to merge |
castastrophe
added
run e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo page