Skip to content

fix: pfe-health-index color support in IE11 #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kylebuch8 merged 1 commit into from
Jul 21, 2020
Merged

fix: pfe-health-index color support in IE11 #993

kylebuch8 merged 1 commit into from
Jul 21, 2020

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Jul 21, 2020 •
edited
Loading

pfe-health-index

IE11 support for health index colors:

Screen Shot 2020-07-21 at 9 16 19 AM

Related issue

Preview

Link(s) to demo page(s) where this element can be viewed:

What has changed and why

Added IE11 fallback styles.

Testing instructions

  1. Open the health index demo page in IE11.
  2. Ensure color renders appropriately for each state.

Browser requirements

Your component should work in all of the following environments:

  • Internet Explorer 11 (should be useable, not pixel perfect)

Ready-for-merge Checklist

Check off items as they are completed. Feel free to delete items if they are not applicable.

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Browser testing passed.
  • Repository compiles and tests pass.
  • Changelog updated (not needed for documentation updates).

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@castastrophe castastrophe added bug styles An issue or PR pertaining only to CSS/Sass ready: code review Ready for code review! priority: high Severity level: 1 size: sm Sizing label; indicates a quick, relatively easy task labels Jul 21, 2020
@castastrophe castastrophe self-assigned this Jul 21, 2020
kylebuch8
kylebuch8 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long Gone Traveling Minstrel

@kylebuch8 kylebuch8 merged commit a7240fd into master Jul 21, 2020
@kylebuch8 kylebuch8 deleted the fix-issue-992-pfe-health-index-colors branch July 21, 2020 13:30
@kylebuch8 kylebuch8 linked an issue Jul 21, 2020 that may be closed by this pull request
IE11: pfe-health-index colors #992
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylebuch8 kylebuch8 kylebuch8 approved these changes

Assignees

@castastrophe castastrophe

Labels

priority: high Severity level: 1 ready: code review Ready for code review! size: sm Sizing label; indicates a quick, relatively easy task styles An issue or PR pertaining only to CSS/Sass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IE11: pfe-health-index colors

3 participants

@castastrophe @kylebuch8