fix(Cards): refactor sub-component references #2935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2935.surge.sh |
jeff-phillips-18
previously approved these changes
Sep 18, 2019
Contributor
|
Looks like tests may have to be updated, otherwise looks good |
Due to patternfly#2931, rearrange the way `Card` includes the component's sub-components to match the way the `Wizard` (and all other components) does it. The new style will allow the subcomponent references to survive webpack tree shaking.
sjd78
force-pushed
the
pf3-card-tree-shaking
branch
from
0507ca0 to
465cac2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2935 +/- ##
==========================================
+ Coverage 68.94% 68.98% +0.04%
==========================================
Files 858 858
Lines 23590 23612 +22
Branches 1887 1887
==========================================
+ Hits 16263 16288 +25
+ Misses 6367 6364 -3
Partials 960 960
Continue to review full report at Codecov.
|
jeff-phillips-18
approved these changes
Oct 16, 2019
dlabrecq
approved these changes
Oct 16, 2019
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #2931, rearrange the way
Cardincludes the component's sub-components to match the way theWizard(and all other components) does it. The new style will allow the sub-component references to survive webpack tree shaking.