Skip to content

Distribution css brings along 404 out of box #673

@seanforyou23

Description

@seanforyou23

I've put together a simple demo app that illustrates the problem in a basic use case.

https://github.com/seanforyou23/pf-react-styling

In a nutshell the problem is that, when loading patternfly-react.css stylesheet in standard fashion through a link tag on a webpage, it fails, because it contains an unreliable reference to files that are not guaranteed to exist - Typeahead.css - as its not shipped along with our distribution assets.

In the demo app I mentioned, you'll see I also included references to several other popular ui styling packages such as patternfly core, bootstrap, foundation and materialize so we can compare the results. Patternfly-react styles load just fine, just that they bring along with them the extra baggage of a 404 on Typeahead.

screen shot 2018-09-27 at 4 28 00 pm

Of course this reference may resolve just fine depending on your environment.. but the point is that this is a very simple yet critical use case that should work without issue - out of the box.

Should we run pre-process import references for third party libs like this before final bundles are produced? Or maybe load them over http? I like the idea of keeping this package self contained, so hoping we can find a way to parse these types of dependencies ahead of time, like we do other assets.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions