File upload multiple - allow custom message text for uploaded files

[mcarrano]

Want to allow for customizing message text associated with uploaded files.

Original request: patternfly/patternfly#4915

Core PR: patternfly/patternfly#5161

[wise-king-sullyman]

@mcarrano the requested custom message is being enabled through the Progress component which File Upload Multiple uses internally, so changes will be needed in Progress as well as File Upload Multiple to enable the requested behavior.

I feel like it would make sense to have separate issues for implementing the text on the Progress component and updating File Upload Multiple to take advantage of the updated Progress API.

It would probably be a bit tight, but I don't think it would be unreasonable to have both issues in the 2022.15 milestone so that we aren't doing PF4 feature development post 2022.15, and I would be willing to take them both on since I'm already very familiar with the File Upload Multiple component and the core change linked here. Plus I may be able to get started on them before we formally kick the next sprint off.

Thoughts?

[mcarrano]

Sure. I will open an additional issue and link it here.

[wise-king-sullyman]

@mcarrano did you have anything in mind for what (if any) demo/example would be added as part of this feature add? A whole new example for this small tweak feels a bit odd to me when even the basic example for file upload - multiple has so many moving parts.

[mcarrano]

That's a good question @wise-king-sullyman . The original ask was for something like what is shown below:

Basically it's the ability to display an error if one of the uploads fails. Any way to just use the Basic example but just force an error so someone can see how that's displayed using Helper text?

[wise-king-sullyman]

@mcarrano I believe I could do something like that, maybe not forcing a real error but at least making it appear like an error has occurred. Would you just want another checkbox added that causes files uploaded to show as though they've failed?

Edit: I figured out a way to actually cause an error to be encountered, should have a PR up shortly.