fix(subcomponents): Make all subcomponents available from base component #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PatternFly-React preview: https://916-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3228
💛 - Coveralls |
Member
Author
|
See #894 (comment) for context. |
cdcabrera
reviewed
Nov 14, 2018
Member
cdcabrera
left a comment
cdcabrera
left a comment
There was a problem hiding this comment.
First round quick review, couple of notes/questions and a possible issue
packages/patternfly-3/patternfly-react/src/components/Cards/Card.js
Outdated
Show resolved
Hide resolved
packages/patternfly-3/patternfly-react/src/components/Cards/Card.js
Outdated
Show resolved
Hide resolved
cdcabrera
reviewed
Nov 14, 2018
Member
cdcabrera
left a comment
cdcabrera
left a comment
There was a problem hiding this comment.
Round 2... optional update, comment/question
...ges/patternfly-3/patternfly-react/src/components/ToastNotification/TimedToastNotification.js
Show resolved
Hide resolved
packages/patternfly-3/patternfly-react/src/components/TypeAheadSelect/TypeAheadSelect.js
Show resolved
Hide resolved
This allows all subcomponents to be available from the pf-react packages.
jeff-phillips-18
force-pushed
the
fixes
branch
from
b63fc27 to
f557693
Compare
cdcabrera
approved these changes
Nov 14, 2018
mareklibra
approved these changes
Nov 15, 2018
dtaylor113
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows all subcomponents to be available from the pf-react packages.
@mareklibra