feat(DragDrop next): add multiple drop zone support #10614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-10614.surge.sh A11y report: https://patternfly-react-pr-10614-a11y.surge.sh |
kmcfaul
changed the title
kmcfaul
changed the title
tlabaj
requested review from
a team,
mcoker,
nicolethoen and
tlabaj
and removed request for
a team
Contributor
Author
|
Opened patternfly/patternfly-design#1313 for drop zone styling. |
nicolethoen
approved these changes
Jul 9, 2024
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Small nit but this looks really good to me! :) Awesome work
| * Default and defaultWithHandle varaints wrap the draggable object in a div. | ||
| * DataList vairant wraps the draggable object in a DataListItem | ||
| * DualListSelectorList variant wraps the draggable objects in a DualListSelectorListItem and a div.pf-c-dual-list-selector__item-text element | ||
| * TableComposable variant wraps the draggable objects in TODO |
Contributor
There was a problem hiding this comment.
Theres is a lingering TODO in this prop description. I wonder if it could be cleaned up.
thatblindgeye
approved these changes
Jul 10, 2024
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
kmcfaul
added a commit
to kmcfaul/patternfly-react
that referenced
this pull request
Jul 17, 2024
* feat(DragDrop-next): add multiple drop zone support * update dupe ids * pass 2 - fixed collision bugs and ref passthrough * refactor DragDropSort to use DragDropContainer * move DraggableObject to Container * updated import, remove unused context * remove green styling for dragover * fix overlay styling, glob import * lock * revert glob * update type
tlabaj
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat(DragDrop next): add multiple drop zone support (#10614) * feat(DragDrop-next): add multiple drop zone support * update dupe ids * pass 2 - fixed collision bugs and ref passthrough * refactor DragDropSort to use DragDropContainer * move DraggableObject to Container * updated import, remove unused context * remove green styling for dragover * fix overlay styling, glob import * lock * revert glob * update type * fix doubled directory and merge changes into base * lock * fix var/tokens, remove double example, fix DLS context import * fix variant descriptions, remove TableComposable variant * snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10524
DragDropContainer, a more general-use container for drag operationsDroppableto be functional (was a placeholder component)DraggableObjectidto bestring | number(fromstring) to match dndkit'sUniqueIdentiferthat is used for identification, and moved it toDragDropContainer.DataListandDualListSelectorListto work withDroppablestructure and hooks (DataList - reformatted to functional component, DualListSelectorList - added forward ref).DragDropSortto useDragDropContainerunder the hoodDroppableContext(was placeholder and unneeded)Open questions/issues:
@dnd-kit/dependencies #10590 (review) so I don't think it's related to the specific changes in this PR. cc @mcoker any thoughts about this? You can inspect the drag overlay by using the keyboard to initiate a drag (space) and then inspecting the element.nextfolder whereDroppablecollides withreact-core'sDroppable. I could only resolve this by aliasingDroppablein the examples, but this should only be an issue with our docs framework and not required by a user.