Skip to content

Conversation

@jeff-phillips-18
Copy link
Member

Provides the ability to add Threshold items to the legend if either text or a function is provided.

@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://1074-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3606

  • 3 of 7 (42.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 82.042%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/patternfly-3/patternfly-react/src/components/Chart/BulletChart/BulletChart.js 3 7 42.86%
Totals Coverage Status
Change from base Build 3605: -0.06%
Covered Lines: 4265
Relevant Lines: 4915

💛 - Coveralls

Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Jeff!

@dtaylor113
Copy link
Member

I'm a little confused. Should the bar turn orange and/or red when over Warning or Error thresholds...like the arc does in gauge charts?

@jeff-phillips-18
Copy link
Member Author

No, the bar remains the same. The threshold lines are used as indicators. See https://www.patternfly.org/pattern-library/data-visualization/bullet-chart/#design

@dtaylor113
Copy link
Member

No, the bar remains the same. The threshold lines are used as indicators. See https://www.patternfly.org/pattern-library/data-visualization/bullet-chart/#design

Just concerned, because on that page it has:
image

What denotes ''poor, good, excellent" for the bars?

@jeff-phillips-18
Copy link
Member Author

That would be up to the application to decide. That text is meant for the range bars.

@dtaylor113 dtaylor113 merged commit 49c3b94 into patternfly:master Dec 18, 2018
@jeff-phillips-18 jeff-phillips-18 deleted the bullet-chart branch May 12, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants