Skip to content

fix(MenuToggle): incorrect inheritance of HTMLInputElement #11145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 1 commit into from
Nov 13, 2024
Merged

fix(MenuToggle): incorrect inheritance of HTMLInputElement #11145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/MenuToggle/MenuToggleCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export interface MenuToggleCheckboxProps
/** Flag to set the default checked value of the checkbox when it is uncontrolled by React state.
* To make the checkbox controlled instead use the isChecked prop, but do not use both.
*/
defaultChecked?: boolean | null;
defaultChecked?: boolean;
/** A callback for when the checkbox selection changes */
onChange?: (checked: boolean, event: React.FormEvent<HTMLInputElement>) => void;
/** Element to be rendered inside the <span> */
Expand Down