Skip to content

fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with RhUiSortDownSmallToLargeIcon#12485

Merged
nicolethoen merged 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-pficon-sort-common-asc-icon-with-rh-ui-sort-down-small-to-large
Jun 18, 2026
Merged

fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with RhUiSortDownSmallToLargeIcon#12485
nicolethoen merged 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-pficon-sort-common-asc-icon-with-rh-ui-sort-down-small-to-large

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 16, 2026

Copy link
Copy Markdown
Member

First commit is RhUiSortDownSmallToLargeIcon but it looked weird in deprecated demos. Second commit is with Microns version.

Part of #12401. Breaking into separate PRs so it is easier to review.

Made with Cursor

Summary by CodeRabbit

  • Style

    • Updated the sort icons used in DualListSelector examples and demo applications to match current design standards, ensuring consistent visuals for both available and chosen lists (including deprecated variants).
  • Documentation

    • Refreshed sort icon references in DualListSelector documentation pages for clearer, up-to-date example rendering.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 26b2562f-25e7-41b6-9ffe-aa58edf1ffd7

📥 Commits

Reviewing files that changed from the base of the PR and between 39aff8c and 58d4ad0.

📒 Files selected for processing (7)
  • packages/react-core/src/components/DualListSelector/examples/DualListSelector.md
  • packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx
  • packages/react-drag-drop/src/components/DragDrop/examples/DragDrop.md
  • packages/react-drag-drop/src/components/DragDrop/examples/DragDropDemos.md
✅ Files skipped from review due to trivial changes (7)
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx
  • packages/react-core/src/components/DualListSelector/examples/DualListSelector.md
  • packages/react-drag-drop/src/components/DragDrop/examples/DragDrop.md
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md
  • packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
  • packages/react-drag-drop/src/components/DragDrop/examples/DragDropDemos.md

Walkthrough

Replaces PficonSortCommonAscIcon with RhMicronsSortDownSmallToLargeIcon as the ascending sort icon across DualListSelector current and deprecated examples, DragDrop documentation files, and integration demo components. No logic, state, or component APIs are changed.

Changes

Sort Icon Replacement Across DualListSelector and DragDrop

Layer / File(s) Summary
DualListSelector core examples icon update
packages/react-core/src/components/DualListSelector/examples/DualListSelector.md, packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
Updates the icon import in the .md file and replaces PficonSortCommonAscIcon with RhMicronsSortDownSmallToLargeIcon in both the Available and Chosen sort button icon props.
Deprecated DualListSelector examples icon update
packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md, packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx, packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx
Applies the same icon import swap and prop update to all three deprecated DualListSelector example files.
DragDrop docs unused import removal
packages/react-drag-drop/src/components/DragDrop/examples/DragDrop.md, packages/react-drag-drop/src/components/DragDrop/examples/DragDropDemos.md
Removes the now-unused PficonSortCommonAscIcon import from both DragDrop documentation files.
Integration demo sort icon update
packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorWithActionsDemo.tsx, packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDeprecatedDemo/DualListSelectorDeprecatedWithActionsDemo.tsx
Replaces the ascending sort icon import and its usage in sortHelper.getIcon / sort button icon props in both integration demo components.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • thatblindgeye
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title references 'RhUiSortDownSmallToLargeIcon' but the actual changes throughout the codebase use 'RhMicronsSortDownSmallToLargeIcon'. The title is misleading about which icon replacement was actually implemented. Update the PR title to accurately reflect the actual icon used: 'fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with RhMicronsSortDownSmallToLargeIcon'
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rebeccaalpert rebeccaalpert marked this pull request as draft June 16, 2026 20:29
@patternfly-build

patternfly-build commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-pficon-sort-common-asc-icon-with-rh-ui-sort-down-small-to-large branch from 88e73bc to 4568ea6 Compare June 16, 2026 21:39
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 16, 2026 21:43

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs rebase

rebeccaalpert and others added 2 commits June 18, 2026 11:08
…UiSortDownSmallToLargeIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
…nstead of RhUiSortDownSmallToLargeIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-pficon-sort-common-asc-icon-with-rh-ui-sort-down-small-to-large branch from 39aff8c to 58d4ad0 Compare June 18, 2026 15:45
@nicolethoen nicolethoen merged commit 909f747 into patternfly:main Jun 18, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants