Skip to content

fix(BookOpenIcon): Replace BookOpenIcon with RhUiLearnFillIcon#12487

Merged
thatblindgeye merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-book-open-icon-with-rh-ui-learn-fill
Jun 17, 2026
Merged

fix(BookOpenIcon): Replace BookOpenIcon with RhUiLearnFillIcon#12487
thatblindgeye merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-book-open-icon-with-rh-ui-learn-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 16, 2026

Copy link
Copy Markdown
Member

Part of #12401. Breaking into separate PRs so it is easier to review.

Made with Cursor

Summary by CodeRabbit

Release Notes

  • Documentation
    • Updated List component examples with refined icon selections.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert marked this pull request as draft June 16, 2026 20:29
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cad331fc-14bc-4180-ba56-6ecc32d5a369

📥 Commits

Reviewing files that changed from the base of the PR and between 7d594f4 and 77b3d86.

📒 Files selected for processing (3)
  • packages/react-core/src/components/List/examples/List.md
  • packages/react-core/src/components/List/examples/ListIcons.tsx
  • packages/react-core/src/components/List/examples/ListLargeIcons.tsx

Walkthrough

Three List example files are updated to replace BookOpenIcon with RhUiLearnFillIcon as the first list item icon. This affects the imports and icon prop in ListIcons.tsx and ListLargeIcons.tsx, and the import reference in List.md. No logic, structure, or other icons are changed.

Changes

List Example Icon Swap

Layer / File(s) Summary
Replace BookOpenIcon with RhUiLearnFillIcon
packages/react-core/src/components/List/examples/List.md, packages/react-core/src/components/List/examples/ListIcons.tsx, packages/react-core/src/components/List/examples/ListLargeIcons.tsx
Removes BookOpenIcon import and replaces it with RhUiLearnFillIcon in both example components and the documentation import reference; all other list items and icons remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • thatblindgeye
  • kmcfaul
  • bekah-stephens
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing BookOpenIcon with RhUiLearnFillIcon across example components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 16, 2026 20:37
@patternfly-build

patternfly-build commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@thatblindgeye thatblindgeye merged commit fa56c9e into patternfly:main Jun 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants