-
Notifications
You must be signed in to change notification settings - Fork 377
fix(TypeAhead): upgrade typeahead to v3.4.1 #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TypeAhead): upgrade typeahead to v3.4.1 #1493
Conversation
|
I was in the process of adapting my still-open PR for this dependency #1367 to push its version to 3.4.1 when I noticed your PR here. Whoops! I neglected to update the props in the stories like you did, so I'll go ahead and close mine. You'll need to update some jest snapshots, though. |
|
PatternFly-React preview: https://1493-pr-patternfly-react-patternfly.surge.sh |
|
Oops, feel free to continue in your PR as I am afk, |
|
No problem, I'm not blocked by this (my PR was sitting waiting for a reviewer anyway). |
8e0ed99 to
2a023d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1493 +/- ##
========================================
Coverage ? 83.4%
========================================
Files ? 545
Lines ? 5653
Branches ? 12
========================================
Hits ? 4715
Misses ? 936
Partials ? 2
Continue to review full report at Codecov.
|
| <br /> | ||
| <h2>Multiple Selection</h2> | ||
| <TypeAheadSelect | ||
| id="some-typeahead" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are ID's required now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They will be required in the next version,
Currently it just raises an unpleasant deprecation warning each render
fix #1491
fix #1366
What:
Additional issues: