Skip to content

Conversation

@Ron-Lavi
Copy link
Collaborator

@Ron-Lavi Ron-Lavi commented Mar 4, 2019

fix #1491
fix #1366

What:

Additional issues:

@mturley
Copy link
Collaborator

mturley commented Mar 4, 2019

I was in the process of adapting my still-open PR for this dependency #1367 to push its version to 3.4.1 when I noticed your PR here. Whoops!

I neglected to update the props in the stories like you did, so I'll go ahead and close mine. You'll need to update some jest snapshots, though.

@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://1493-pr-patternfly-react-patternfly.surge.sh

@Ron-Lavi
Copy link
Collaborator Author

Ron-Lavi commented Mar 4, 2019

Oops, feel free to continue in your PR as I am afk,
I will be able to continue only tomorrow and don't want to block you.

@mturley
Copy link
Collaborator

mturley commented Mar 4, 2019

@LaViro would you mind adding "fix #1366" to your description here since your upgrade solves my issue too?

@mturley
Copy link
Collaborator

mturley commented Mar 4, 2019

No problem, I'm not blocked by this (my PR was sitting waiting for a reviewer anyway).

@Ron-Lavi Ron-Lavi force-pushed the fix/upgrade-typeahead branch from 8e0ed99 to 2a023d0 Compare March 5, 2019 08:30
@codecov-io
Copy link

codecov-io commented Mar 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@329f285). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1493   +/-   ##
========================================
  Coverage          ?   83.4%           
========================================
  Files             ?     545           
  Lines             ?    5653           
  Branches          ?      12           
========================================
  Hits              ?    4715           
  Misses            ?     936           
  Partials          ?       2
Flag Coverage Δ
#patternfly3 84.89% <ø> (?)
#patternfly4 80.68% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329f285...2a023d0. Read the comment docs.

<br />
<h2>Multiple Selection</h2>
<TypeAheadSelect
id="some-typeahead"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ID's required now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will be required in the next version,
Currently it just raises an unpleasant deprecation warning each render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typeahead warnings after version update PF3: react-bootstrap-typeahead version should be bumped to bring in bugfixes

7 participants