Skip to content

Conversation

@glekner
Copy link
Contributor

@glekner glekner commented May 5, 2019

What:
Add disableNext,disablePrev Props to the Paginator component.

@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://1928-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

codecov-io commented May 5, 2019

Codecov Report

Merging #1928 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1928   +/-   ##
=======================================
  Coverage   82.63%   82.63%           
=======================================
  Files         624      624           
  Lines        6875     6875           
  Branches       93       93           
=======================================
  Hits         5681     5681           
  Misses       1154     1154           
  Partials       40       40
Flag Coverage Δ
#patternfly3 84.89% <100%> (ø) ⬆️
#patternfly4 79.37% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...y-react/src/components/Pagination/PaginationRow.js 88.88% <ø> (ø) ⬆️
...act/src/components/Pagination/PaginationRowBack.js 45.45% <ø> (ø) ⬆️
.../src/components/Pagination/PaginationRowForward.js 45.45% <ø> (ø) ⬆️
...rnfly-react/src/components/Pagination/Paginator.js 57.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dedeee...8932d97. Read the comment docs.

@tlabaj tlabaj requested a review from priley86 May 8, 2019 17:10
@tlabaj tlabaj added the PF3 label May 8, 2019
Copy link
Member

@priley86 priley86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues - this seems to add some flexibility if one wants to explicitly disable forward/back

@glekner
Copy link
Contributor Author

glekner commented May 12, 2019

@jeff-phillips-18 can you approve? thanks

@jeff-phillips-18 jeff-phillips-18 merged commit b0fb965 into patternfly:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants