fix(deps): updated deps to fix peer conflict in eslint-plugin-pf-react #8656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8656.surge.sh A11y report: https://patternfly-react-pr-8656-a11y.surge.sh |
This was referenced Feb 6, 2023
Comment on lines
-109
to
-111
| "patternfly-react/no-anonymous-functions": "error", | ||
| "patternfly-react/no-anonymous-functions": "off", | ||
| "prefer-const": "error", | ||
| "prettier/prettier": "error", |
Contributor
Author
nicolethoen
approved these changes
Feb 7, 2023
gitdallas
approved these changes
Feb 7, 2023
Contributor
|
@wise-king-sullyman - just need to resolve conflicts |
tlabaj
approved these changes
Feb 8, 2023
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
LGTM once conflicts are resolved.
wise-king-sullyman
force-pushed
the
eslint-plugin-pf-react-conflicting-deps
branch
from
8567ac3 to
2941015
Compare
wise-king-sullyman
force-pushed
the
eslint-plugin-pf-react-conflicting-deps
branch
from
2941015 to
ad9c0e7
Compare
wise-king-sullyman
deleted the
eslint-plugin-pf-react-conflicting-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7893
Additional issues: