Skip to content

fix(deps): updated deps to fix peer conflict in eslint-plugin-pf-react #8656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2023
Merged

fix(deps): updated deps to fix peer conflict in eslint-plugin-pf-react #8656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5e3c1e
fix(deps): updated deps to fix peer conflict in eslint-plugin-pf-react
wise-king-sullyman Feb 3, 2023
ad9c0e7
chore(linting): removed some rule customization that's no longer needed
wise-king-sullyman Feb 6, 2023
9b06888
chore(deps): update lockfile
wise-king-sullyman Feb 8, 2023
19b89f0
chore(deps): bump react-core version to latest alpha
wise-king-sullyman Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@
"never"
],
"patternfly-react/import-tokens-icons": "error",
"patternfly-react/no-anonymous-functions": "error",
"patternfly-react/no-anonymous-functions": "off",
"prefer-const": "error",
"prettier/prettier": "error",
Comment on lines -109 to -111
Copy link
Contributor Author

@wise-king-sullyman wise-king-sullyman Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled these rules temporarily as changes to linting deps are now causing a lot of errors to be thrown. I've created #8657 and #8658 as followup issues.

"prettier/prettier": "off",
"radix": [
"error",
"as-needed"
Expand Down
16 changes: 8 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"homepage": "https://github.com/patternfly/patternfly-react#readme",
"devDependencies": {
"@babel/core": "^7.0.0",
"@babel/core": "^7.20.12",
"@babel/plugin-proposal-class-properties": "^7.0.0",
"@babel/plugin-proposal-decorators": "^7.8.3",
"@babel/plugin-proposal-object-rest-spread": "^7.0.0",
Expand All @@ -42,14 +42,14 @@
"@types/jest": "27.0.2",
"@types/react": "^18",
"@types/react-dom": "^18",
"@typescript-eslint/eslint-plugin": "^4.4.1",
"@typescript-eslint/parser": "^4.4.1",
"@typescript-eslint/eslint-plugin": "^5.50.0",
"@typescript-eslint/parser": "^5.50.0",
"babel-jest": "^27.2.5",
"concurrently": "^5.3.0",
"eslint": "^7.11.0",
"eslint-plugin-markdown": "^1.0.2",
"eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-react": "^7.21.4",
"eslint": "^8.33.0",
"eslint-plugin-markdown": "^1.0.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-react": "^7.32.2",
"fs-extra": "^6.0.1",
"glob": "^7.1.2",
"husky": "^4.3.0",
Expand All @@ -59,7 +59,7 @@
"lint-staged": "^10.4.2",
"mutation-observer": "^1.0.3",
"plop": "^2.0.0",
"prettier": "^1.18.3",
"prettier": "^2.8.3",
"react": "^18",
"react-dom": "^18",
"surge": "^0.23.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-plugin-patternfly-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"homepage": "https://github.com/patternfly/patternfly-react/blob/main/packages/eslint-plugin/README.md",
"dependencies": {
"@babel/eslint-parser": "^7.19.1",
"eslint-config-airbnb": "^16.1.0",
"eslint-config-prettier": "^2.9.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-prettier": "^8.6.0",
"eslint-config-standard": "^11.0.0",
"eslint-config-standard-jsx": "^5.0.0",
"eslint-config-standard-react": "^6.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-integration/demo-app-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"serve:demo-app": "node scripts/serve"
},
"dependencies": {
"@patternfly/react-core": "^5.0.0-alpha.5",
"@patternfly/react-core": "^5.0.0-alpha.6",
"react": "^18",
"react-dom": "^18",
"react-router": "^5.3.3",
Expand Down
14 changes: 7 additions & 7 deletions scripts/verifyPatternflyVersions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ function setDependency(dependencies, package, version) {
}

async function verifyPatternflyVersions() {
const packages = await new Project(__dirname).getPackages();
const packages = await Project.getPackages();

packages.forEach(package => {
packages.forEach((package) => {
accumulateDependencies(package.name, { [package.name]: `^${package.version}` });
accumulateDependencies(package.name, package.dependencies);
accumulateDependencies(package.name, package.devDependencies);
Expand All @@ -52,13 +52,13 @@ async function verifyPatternflyVersions() {
.sort((a, b) => semver.compare(a.replace(/^\^/, ''), b.replace(/^\^/, '')))
.pop();
Object.keys(versions)
.filter(version => version !== highestVersion)
.map(version => versions[version])
.forEach(mismatchedPackages => {
.filter((version) => version !== highestVersion)
.map((version) => versions[version])
.forEach((mismatchedPackages) => {
console.log(`Writing ${dep}@${highestVersion}:`);
mismatchedPackages
.map(package => packages.find(p => p.name === package))
.forEach(package => {
.map((package) => packages.find((p) => p.name === package))
.forEach((package) => {
console.log(package.manifestLocation);
setDependency(package.dependencies, dep, highestVersion);
setDependency(package.devDependencies, dep, highestVersion);
Expand Down
Loading