fix(deps): updated to the latest core alpha #8688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8688.surge.sh A11y report: https://patternfly-react-pr-8688-a11y.surge.sh |
gitdallas
approved these changes
Feb 15, 2023
jenny-s51
reviewed
Feb 15, 2023
Contributor
Author
|
Good catch! that's likely a side effect of the popper defaulting to appending things inline by default. But it is already an existing issue on the v5 branch, so I will open a bug issue to track. |
Contributor
Author
jenny-s51
approved these changes
Feb 15, 2023
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Awesome, thank you for clarifying @nicolethoen and for opening the bug for tracking. In that case LGTM!
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #
Additional issues: