fix(icons): fixed pficons naming overrides #8932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8932.surge.sh A11y report: https://patternfly-react-pr-8932-a11y.surge.sh |
nicolethoen
approved these changes
Apr 9, 2023
thatblindgeye
approved these changes
Apr 10, 2023
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8917
Additional issues: Bug identified originally in #8825
This PR returns the 12 PF icon name overrides (ex: rename
filtertofilter-alt) that were mistakenly removed and thus causing these 12 PF icons to override (and replace) Font Awesome icons with the same names.Missing icons: http://patternfly-react-v5.surge.sh/icons
Fix preview with icons returned: https://patternfly-react-pr-8932.surge.sh/icons
Additional background
generateIcons.mjsandpatternflyIcons.mjs. There are actually 12 PF icons that we manually rename to avoid naming conflicts with FA icons.patternflyIcons.mjsgenerateIcons.mjsto import directly from the Core dependency, meaningpatternflyIcons.mjswas never being used and thus the renaming never happened.