Charts - fix broken tooltip examples #8707
Merged
+23
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabrecq
changed the title
Contributor
|
Preview: https://patternfly-react-pr-8707.surge.sh A11y report: https://patternfly-react-pr-8707-a11y.surge.sh |
dlabrecq
force-pushed
the
v5-8591-tooltip-example
branch
from
01aef28 to
da36972
Compare
dlabrecq
force-pushed
the
v5-8591-tooltip-example
branch
from
14f46c0 to
fef29d9
Compare
nicolethoen
approved these changes
Feb 20, 2023
tlabaj
reviewed
Feb 20, 2023
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
I am seeing these two issues in the console when I load tooltip examples.
ChartContainer was missing height and width
Member
Author
|
@tlabaj That particular error is unrelated, it's caused by the "CSS overflow" example. The |
kmcfaul
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the chart's custom tooltip example is working, I'm seeing some warnings in the browser console. Therefore, I've refactored the example to reference
ChartLabelinstead.Closes #8591