Skip to content

Charts - fix broken tooltip examples #8707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Charts - fix broken tooltip examples #8707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fef29d9
fix(charts) fix broken tooltip examples
dlabrecq Feb 17, 2023
af083bc
chore(charts) removed ChartContainer from CSS overflow example
dlabrecq Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/react-charts/src/components/ChartLegend/examples/ChartLegend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,18 +605,18 @@ import { Tooltip } from '@patternfly/react-core';
class TooltipPieChart extends React.Component {
constructor(props) {
super(props);

// Custom legend label component
// Note: Tooltip outputs a div tag, so we wrap that using a foreignObject
this.LegendLabel = ({datum, x, y, ...rest}) => (
<g>
<foreignObject height="100%" width="100%" x={x - 10} y={y - 12}>
<Tooltip content={datum.name} enableFlip >
<ChartLabel {...rest} />
</Tooltip>
</foreignObject>
</g>
);
// Note: Tooltip wraps children with a div tag, so we add a reference to ChartLabel instead
this.LegendLabel = ({datum, ...rest}) => {
const ref = React.createRef();
return (
<g ref={ref}>
<ChartLabel {...rest} />
<Tooltip content={datum.name} enableFlip reference={ref} />
</g>
);
}

// Custom legend component
this.getLegend = (legendData) => (
Expand Down
26 changes: 12 additions & 14 deletions packages/react-charts/src/components/ChartTooltip/examples/ChartTooltip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,16 +608,16 @@ class TooltipPieChart extends React.Component {
super(props);

// Custom legend label component
// Note: Tooltip outputs a div tag, so we wrap that using a foreignObject
this.LegendLabel = ({datum, x, y, ...rest}) => (
<g>
<foreignObject height="100%" width="100%" x={x - 10} y={y - 12}>
<Tooltip content={datum.name} enableFlip >
<ChartLabel {...rest} />
</Tooltip>
</foreignObject>
</g>
);
// Note: Tooltip wraps children with a div tag, so we add a reference to ChartLabel instead
this.LegendLabel = ({datum, ...rest}) => {
const ref = React.createRef();
return (
<g ref={ref}>
<ChartLabel {...rest} />
<Tooltip content={datum.name} enableFlip reference={ref} />
</g>
);
}

// Custom legend component
this.getLegend = (legendData) => (
Expand Down Expand Up @@ -767,7 +767,7 @@ This demonstrates an alternate way of applying tooltips using CSS overflow inste

```js
import React from 'react';
import { ChartArea, ChartContainer, ChartGroup, ChartLabel, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts';
import { ChartArea, ChartGroup, ChartLabel, ChartThemeColor, ChartVoronoiContainer } from '@patternfly/react-charts';

<div className="ws-react-charts-tooltip-overflow">
<div style={{ height: '100px', width: '400px' }}>
Expand All @@ -790,11 +790,9 @@ import { ChartArea, ChartContainer, ChartGroup, ChartLabel, ChartThemeColor, Cha
{ name: 'Cats', x: '2018', y: 6 }
]}
/>
<ChartLabel text="CPU utilization" dy={120}/>
</ChartGroup>
</div>
<ChartContainer title="CPU utilization">
<ChartLabel text="CPU utilization" dy={15}/>
</ChartContainer>
</div>
```

Expand Down