Typescript support for react-core #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PatternFly-React preview: https://884-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3521
💛 - Coveralls |
dmiller9911
reviewed
Dec 4, 2018
packages/patternfly-4/react-core/src/components/Avatar/Avatar.tsx
Outdated
Show resolved
Hide resolved
dmiller9911
reviewed
Dec 4, 2018
packages/patternfly-4/react-core/src/components/Avatar/Avatar.tsx
Outdated
Show resolved
Hide resolved
dmiller9911
reviewed
Dec 5, 2018
packages/patternfly-4/react-core/src/components/Avatar/Avatar.tsx
Outdated
Show resolved
Hide resolved
dmiller9911
reviewed
Dec 5, 2018
packages/patternfly-4/react-core/src/components/Avatar/Avatar.tsx
Outdated
Show resolved
Hide resolved
dmiller9911
reviewed
Dec 5, 2018
packages/patternfly-4/react-core/src/components/Avatar/Avatar.tsx
Outdated
Show resolved
Hide resolved
dlabaj
changed the title
tlabaj
previously approved these changes
Dec 10, 2018
jschuler
reviewed
Dec 10, 2018
jschuler
approved these changes
Dec 10, 2018
tlabaj
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial typescript support with Babel 6.
What:
Adds support for typescript to react-core only. Currently uses tsc for typescript transpiling and babel 6.
Additional issues:
Still need to add tslint. Should also convert a component to typescript to work out any issues.
Gatsby Demo can be found here: http://chilly-paste.surge.sh/